Skip to content

[ty] WIP: Disambiguate legacy typevars #17994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[ty] WIP: Disambiguate legacy typevars #17994

wants to merge 1 commit into from

Conversation

dcreager
Copy link
Member

@dcreager dcreager commented May 9, 2025

This addresses @carljm's comment #17956 (review) about wanting to disambiguate legacy typevars that are used in multiple generic contexts.

WIP, not ready for review yet

@dcreager dcreager added internal An internal refactor or improvement ty Multi-file analysis & type inference labels May 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025

mypy_primer results

No ecosystem changes detected ✅

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 9, 2025

CodSpeed Performance Report

Merging #17994 will degrade performances by 6.71%

Comparing dcreager/distinct-legacy-typevars (1958671) with main (882a1a7)

Summary

❌ 2 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ ty_check_file[cold] 107 ms 112.1 ms -4.5%
❌ ty_check_file[incremental] 5.4 ms 5.8 ms -6.71%

@Glyphack Glyphack mentioned this pull request Jun 5, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm Awaiting requested review from carljm carljm will be requested when the pull request is marked ready for review carljm is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp will be requested when the pull request is marked ready for review sharkdp is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement ty Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcreager