Skip to content

Stabilize starmap-zip (RUF058) #18525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Stabilize starmap-zip (RUF058) #18525

merged 1 commit into from
Jun 10, 2025

Conversation

ntBre
Copy link
Contributor

@ntBre ntBre commented Jun 7, 2025

Summary

  • Stabilizes RUF058 (starmap-zip) rule by changing it from Preview to Stable
  • Migrates test cases from preview_rules to main rules function
  • Updates snapshots accordingly and removes old preview snapshots

Test plan

  • ✅ Migrated tests from preview to main test function
  • ✅ make check passes
  • ✅ make test passes
  • ✅ make citest passes (no leftover snapshots)

Rule Documentation

@ntBre ntBre force-pushed the brent/release-0.12.0 branch 3 times, most recently from 9252447 to 829acf4 Compare June 9, 2025 00:22
@ntBre ntBre force-pushed the brent/stabilize-ruf058 branch from 3aed7a4 to 2477e04 Compare June 9, 2025 14:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+3 -0 violations, +0 -0 fixes in 3 projects; 52 projects unchanged)

langchain-ai/langchain (+1 -0 violations, +0 -0 fixes) 

+ libs/core/langchain_core/runnables/router.py:209:14: RUF058 [*] `itertools.starmap` called on `zip` iterable

pandas-dev/pandas (+1 -0 violations, +0 -0 fixes) 

+ pandas/tests/arithmetic/test_datetime64.py:2214:32: RUF058 [*] `itertools.starmap` called on `zip` iterable

astropy/astropy (+1 -0 violations, +0 -0 fixes) 

+ astropy/table/soco.py:81:34: RUF058 [*] `itertools.starmap` called on `zip` iterable

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF058 3 3 0 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre added the rule Implementing or modifying a lint rule label Jun 9, 2025
@dylwil3 dylwil3 force-pushed the brent/stabilize-ruf058 branch from 2477e04 to bbc9e3e Compare June 10, 2025 12:45
@ntBre ntBre changed the title Stabilize RUF058 (starmap-zip) Stabilize starmap-zip (RUF058) Jun 10, 2025
@ntBre ntBre merged commit aaf6c9b into brent/release-0.12.0 Jun 10, 2025
34 checks passed
@ntBre ntBre deleted the brent/stabilize-ruf058 branch June 10, 2025 14:43
@ntBre ntBre mentioned this pull request Jun 10, 2025
Merged
2 tasks
@ntBre ntBre added this to the v0.12 milestone Jun 10, 2025
ntBre added a commit that referenced this pull request Jun 10, 2025
@ntBre
Stabilize starmap-zip (RUF058) (#18525)
96913d1 
## Summary
- Stabilizes RUF058 (starmap-zip) rule by changing it from Preview to
Stable
- Migrates test cases from preview_rules to main rules function 
- Updates snapshots accordingly and removes old preview snapshots

## Test plan
- ✅ Migrated tests from preview to main test function
- ✅ `make check` passes
- ✅ `make test` passes  
- ✅ `make citest` passes (no leftover snapshots)

## Rule Documentation
- [Test
file](https://github.com/astral-sh/ruff/blob/main/crates/ruff_linter/src/rules/ruff/mod.rs#L103-L104)
- [Rule documentation](https://docs.astral.sh/ruff/rules/starmap-zip/)
ntBre added a commit that referenced this pull request Jun 11, 2025
@ntBre
Stabilize starmap-zip (RUF058) (#18525)
5cd3fcb 
## Summary
- Stabilizes RUF058 (starmap-zip) rule by changing it from Preview to
Stable
- Migrates test cases from preview_rules to main rules function 
- Updates snapshots accordingly and removes old preview snapshots

## Test plan
- ✅ Migrated tests from preview to main test function
- ✅ `make check` passes
- ✅ `make test` passes  
- ✅ `make citest` passes (no leftover snapshots)

## Rule Documentation
- [Test
file](https://github.com/astral-sh/ruff/blob/main/crates/ruff_linter/src/rules/ruff/mod.rs#L103-L104)
- [Rule documentation](https://docs.astral.sh/ruff/rules/starmap-zip/)
ntBre added a commit that referenced this pull request Jun 11, 2025
@ntBre
Stabilize starmap-zip (RUF058) (#18525)
4dc2b3b 
## Summary
- Stabilizes RUF058 (starmap-zip) rule by changing it from Preview to
Stable
- Migrates test cases from preview_rules to main rules function 
- Updates snapshots accordingly and removes old preview snapshots

## Test plan
- ✅ Migrated tests from preview to main test function
- ✅ `make check` passes
- ✅ `make test` passes  
- ✅ `make citest` passes (no leftover snapshots)

## Rule Documentation
- [Test
file](https://github.com/astral-sh/ruff/blob/main/crates/ruff_linter/src/rules/ruff/mod.rs#L103-L104)
- [Rule documentation](https://docs.astral.sh/ruff/rules/starmap-zip/)
ntBre added a commit that referenced this pull request Jun 12, 2025
@ntBre
Stabilize starmap-zip (RUF058) (#18525)
1e5def8 
## Summary
- Stabilizes RUF058 (starmap-zip) rule by changing it from Preview to
Stable
- Migrates test cases from preview_rules to main rules function 
- Updates snapshots accordingly and removes old preview snapshots

## Test plan
- ✅ Migrated tests from preview to main test function
- ✅ `make check` passes
- ✅ `make test` passes  
- ✅ `make citest` passes (no leftover snapshots)

## Rule Documentation
- [Test
file](https://github.com/astral-sh/ruff/blob/main/crates/ruff_linter/src/rules/ruff/mod.rs#L103-L104)
- [Rule documentation](https://docs.astral.sh/ruff/rules/starmap-zip/)
ntBre added a commit that referenced this pull request Jun 16, 2025
@ntBre
Stabilize starmap-zip (RUF058) (#18525)
eb93b40 
## Summary
- Stabilizes RUF058 (starmap-zip) rule by changing it from Preview to
Stable
- Migrates test cases from preview_rules to main rules function 
- Updates snapshots accordingly and removes old preview snapshots

## Test plan
- ✅ Migrated tests from preview to main test function
- ✅ `make check` passes
- ✅ `make test` passes  
- ✅ `make citest` passes (no leftover snapshots)

## Rule Documentation
- [Test
file](https://github.com/astral-sh/ruff/blob/main/crates/ruff_linter/src/rules/ruff/mod.rs#L103-L104)
- [Rule documentation](https://docs.astral.sh/ruff/rules/starmap-zip/)
ntBre added a commit that referenced this pull request Jun 17, 2025
@ntBre
Stabilize starmap-zip (RUF058) (#18525)
fc19f58 
## Summary
- Stabilizes RUF058 (starmap-zip) rule by changing it from Preview to
Stable
- Migrates test cases from preview_rules to main rules function 
- Updates snapshots accordingly and removes old preview snapshots

## Test plan
- ✅ Migrated tests from preview to main test function
- ✅ `make check` passes
- ✅ `make test` passes  
- ✅ `make citest` passes (no leftover snapshots)

## Rule Documentation
- [Test
file](https://github.com/astral-sh/ruff/blob/main/crates/ruff_linter/src/rules/ruff/mod.rs#L103-L104)
- [Rule documentation](https://docs.astral.sh/ruff/rules/starmap-zip/)
ntBre added a commit that referenced this pull request Jun 17, 2025
@ntBre
Stabilize starmap-zip (RUF058) (#18525)
72c8dc0 
## Summary
- Stabilizes RUF058 (starmap-zip) rule by changing it from Preview to
Stable
- Migrates test cases from preview_rules to main rules function 
- Updates snapshots accordingly and removes old preview snapshots

## Test plan
- ✅ Migrated tests from preview to main test function
- ✅ `make check` passes
- ✅ `make test` passes  
- ✅ `make citest` passes (no leftover snapshots)

## Rule Documentation
- [Test
file](https://github.com/astral-sh/ruff/blob/main/crates/ruff_linter/src/rules/ruff/mod.rs#L103-L104)
- [Rule documentation](https://docs.astral.sh/ruff/rules/starmap-zip/)
carljm added a commit to MatthewMckee4/ruff that referenced this pull request Jun 17, 2025
@carljm
Merge branch 'main' into incorrect-subdiagnostic-for-unresolved-refer…
bef7491 
…ence

* main: (71 commits)
  Bump 0.12.0 (astral-sh#18724)
  Revert "[ty] Offer "Did you mean...?" suggestions for unresolved `from` imports and unresolved attributes (astral-sh#18705)" (astral-sh#18721)
  [`flake8-return`] Stabilize only add `return None` at the end when fixing `implicit-return` (`RET503`) (astral-sh#18516)
  [`pyupgrade`] Stabilize `non-pep695-generic-function` (`UP047`) (astral-sh#18524)
  [`pyupgrade`] Stabilize `non-pep695-generic-class` (`UP046`) (astral-sh#18519)
  [`pandas-vet`] Deprecate `pandas-df-variable-name` (`PD901`) (astral-sh#18618)
  [`flake8-bandit`] Remove `suspicious-xmle-tree-usage` (`S320`) (astral-sh#18617)
  Stabilize `dataclass-enum` (`RUF049`) (astral-sh#18570)
  Stabilize `unnecessary-dict-index-lookup` (`PLR1733`) (astral-sh#18571)
  Remove rust-toolchain.toml from sdist (astral-sh#17925)
  Stabilize `starmap-zip` (`RUF058`) (astral-sh#18525)
  [`flake8-logging`] Stabilize `exc-info-outside-except-handler` (`LOG014`) (astral-sh#18517)
  [`pyupgrade`] Stabilize `non-pep604-annotation-optional` (`UP045`) and preview behavior for `non-pep604-annotation-union` (`UP007`) (astral-sh#18505)
  Stabilize `pytest-warns-too-broad` (`PT030`) (astral-sh#18568)
  Stabilize `for-loop-writes` (`FURB122`) (astral-sh#18565)
  Stabilize `pytest-warns-with-multiple-statements` (`PT031`) (astral-sh#18569)
  Stabilize `pytest-parameter-with-default-argument` (`PT028`) (astral-sh#18566)
  Stabilize `nan-comparison` (`PLW0177`) (astral-sh#18559)
  Stabilize `check-and-remove-from-set` (`FURB132`) (astral-sh#18560)
  Stabilize `unnecessary-round` (`RUF057`) (astral-sh#18563)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylwil3 dylwil3 dylwil3 approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
v0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@ntBre @dylwil3