Skip to content

[ruff] Stabilize invalid-formatter-suppression-comment (RUF028) #18555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

[ruff] Stabilize invalid-formatter-suppression-comment (RUF028) #18555

merged 1 commit into from
Jun 9, 2025

Conversation

dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Jun 8, 2025

No description provided.

@dylwil3 dylwil3 added this to the v0.12 milestone Jun 8, 2025
@dylwil3 dylwil3 added the rule Implementing or modifying a lint rule label Jun 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

pytest-dev/pytest (+1 -0 violations, +0 -0 fixes) 

+ testing/test_assertrewrite.py:2200:1: RUF028 This suppression comment is invalid because it cannot be after a decorator

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF028 1 1 0 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre force-pushed the brent/release-0.12.0 branch from 0370d8a to 040fb6b Compare June 8, 2025 19:55
@ntBre ntBre requested a review from AlexWaygood as a code owner June 8, 2025 19:55
@ntBre ntBre force-pushed the brent/release-0.12.0 branch from 040fb6b to 9252447 Compare June 8, 2025 20:18
@AlexWaygood AlexWaygood removed their request for review June 8, 2025 20:30
@ntBre ntBre force-pushed the brent/release-0.12.0 branch from 9252447 to 829acf4 Compare June 9, 2025 00:22
@dylwil3 dylwil3 force-pushed the dylan/stabilize-ruf028 branch from 21322be to 3694753 Compare June 9, 2025 13:04
ntBre
ntBre approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I checked the ecosystem result, and it's definitely not turning formatting back on!

@dylwil3 dylwil3 merged commit c388897 into brent/release-0.12.0 Jun 9, 2025
34 checks passed
@dylwil3 dylwil3 deleted the dylan/stabilize-ruf028 branch June 9, 2025 17:49
@dylwil3 dylwil3 mentioned this pull request Jun 9, 2025
Merged
2 tasks
ntBre pushed a commit that referenced this pull request Jun 10, 2025
@dylwil3 @ntBre
[ruff] Stabilize invalid-formatter-suppression-comment (RUF028) (…
58a2da2 
…#18555)
ntBre pushed a commit that referenced this pull request Jun 11, 2025
@dylwil3 @ntBre
[ruff] Stabilize invalid-formatter-suppression-comment (RUF028) (…
c4e1c98 
…#18555)
ntBre pushed a commit that referenced this pull request Jun 16, 2025
@dylwil3 @ntBre
[ruff] Stabilize invalid-formatter-suppression-comment (RUF028) (…
f650e46 
…#18555)
ntBre pushed a commit that referenced this pull request Jun 17, 2025
@dylwil3 @ntBre
[ruff] Stabilize invalid-formatter-suppression-comment (RUF028) (…
6764341 
…#18555)
ntBre pushed a commit that referenced this pull request Jun 17, 2025
@dylwil3 @ntBre
[ruff] Stabilize invalid-formatter-suppression-comment (RUF028) (…
c948be4 
…#18555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntBre ntBre ntBre approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
v0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@dylwil3 @ntBre