[pyupgrade] Mark UP008 fix safe if no comments in range
#18683
+402
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ntBre
added
rule
|
Could you resolve the merge conflicts here? Hopefully they're not too much trouble. |
|
@ntBre Done. Wasn't super straight-forward but manageable. Can you take a look so we can get it merged soon-ish before more conflicts arise? Thanks 🙇 |
ntBre
approved these changes
Jun 25, 2025
Comment on lines
+47
to
+50
| /// This rule's fix does not preserve comments. | ||
| /// | ||
| /// In [preview], the fix is marked safe if no comments are attached to the arguments. | ||
| /// Else, the fix is marked unsafe. |
There was a problem hiding this comment.
I think I kind of preferred the old text for the first sentence/paragraph here. The second paragraph looks good, though.
I think you'll also need a reference link for [preview], at least that's what I saw in other rules with a quick grep.
Suggested change
| /// This rule's fix does not preserve comments. | |
| /// | |
| /// In [preview], the fix is marked safe if no comments are attached to the arguments. | |
| /// Else, the fix is marked unsafe. | |
| /// This rule's fix is marked as unsafe because removing the arguments from a call | |
| /// may delete comments that are attached to the arguments. | |
| /// | |
| /// In [preview], the fix is marked safe if no comments are present. | |
| /// | |
| /// [preview]: https://docs.astral.sh/ruff/preview/ |
I guess we can do without the very last sentence if we bring back the old first bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mark
UP008's fix safe if it won't delete comments.Relevant Issues
Fixes: #18533