Skip to content

Make tags non-required for fetching wheel metadata #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

charliermarsh
Copy link
Member

Summary

This looks like a big change but it really isn't. Rather, I just split get_or_build_wheel into separate get_wheel and build_wheel methods internally, which made get_or_build_wheel_metadata capable of not relying on Tags, which in turn makes it easier for us to use the DistributionDatabase in various places without having it coupled to an interpreter or environment (something we already did for SourceDistributionBuilder).

@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Mar 27, 2024
@charliermarsh charliermarsh marked this pull request as ready for review March 27, 2024 23:55
@charliermarsh charliermarsh enabled auto-merge (squash) March 28, 2024 00:01
@charliermarsh charliermarsh merged commit b6ab919 into main Mar 28, 2024
@charliermarsh charliermarsh deleted the charlie/dist-db branch March 28, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant