Disable CosmosPlugin for AF3 #1692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
Deploying astronomer-cosmos with
|
| Latest commit: |
0006a8f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a54c6974.astronomer-cosmos.pages.dev |
| Branch Preview URL: | https://disable-plugin-for-af3.astronomer-cosmos.pages.dev |
pankajkoti
force-pushed
the
disable-plugin-for-af3
branch
from
30814a0 to
26438d2
Compare
pankajkoti
force-pushed
the
disable-plugin-for-af3
branch
from
26438d2 to
0006a8f
Compare
pankajkoti
commented
Apr 24, 2025
|
I tested that the plugin continues to work with AF2 |
dosubot
bot
added
size:XL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
=======================================
Coverage 97.42% 97.43%
=======================================
Files 80 81 +1
Lines 5019 5024 +5
=======================================
+ Hits 4890 4895 +5
Misses 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This could help in the failing test for AF3 in https://github.com/astronomer/astronomer-cosmos/actions/runs/14662043590/job/41148487115?pr=1646 for PR #1646 |
tatiana
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I am not seeing any explicit errors with having the CosmosPlugin in an Airflow 3 env, I think it's still wise that we disable it for now for Airflow 3 until we work on #1587
closes: #1685