$PIPENV_PATH no longer works after default to python3

[leonexis]

Due to 2850374, pythonBin is reset to "python" when whichSync can't find the config-provided path. In my case, that path is "$PIPENV_PATH/bin/python". As whichSync does not understand $PIPENV_PATH, it errors causing the pythonBin to be reset:

    let pythonBin = atom.config.get("ide-python.python") || "python3"
    if (whichSync(pythonBin, { nothrow: true }) === null) {
      pythonBin = "python"
    }

    this.python = replacePipEnvPathVar(pythonBin, venvPath)

Reverting 2850374 resolves this issue, though perhaps there is another way to find if Python 3 is installed that does not conflict with pipenv support.

[aminya]

Does this fix the issue (bringing replacePipEnvPathVar before running whichSync)?

    let pythonBin = atom.config.get("ide-python.python") || "python3"
    pythonBin = replacePipEnvPathVar(pythonBin, venvPath)
    if (whichSync(pythonBin, { nothrow: true }) === null) {
      pythonBin = "python"
    }
	this.python = pythonBin

[leonexis]

Yes, that works perfectly in my case.

  async startServerProcess(projectPath) {
    const venvPath = (await detectPipEnv(projectPath)) || (await detectVirtualEnv(projectPath))
    const pylsEnvironment = Object.assign({}, process.env)
    if (venvPath) {
      pylsEnvironment.VIRTUAL_ENV = venvPath
    }

    let pythonBin = atom.config.get("ide-python.python") || "python3"
    pythonBin = replacePipEnvPathVar(pythonBin, venvPath)
    if (whichSync(pythonBin, { nothrow: true }) === null) {
      pythonBin = "python"
    }
    this.python = pythonBin

    const childProcess = super.spawn(this.python, ["-m", this.getPyLs()], {
      cwd: projectPath,
      env: pylsEnvironment,
    })
    return childProcess
  }

[github-actions]

🎉 This issue has been resolved in version 1.9.7 🎉

The release is available on:

• GitHub release
• Atom package

Your semantic-release bot 📦🚀