Implement the "use typechecking" directive, annotating the source, and checking against the schema if the types are present #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/schema
|
|
||
| permission view: user = viewer | ||
| permission edit: user = viewer | ||
| permission admin: group = viewer |
There was a problem hiding this comment.
Add additional tests for error cases:
:but no type before the=: something |: |
| } | ||
|
|
||
| // Find existing PERMISSION RelationMetadata and update it, or create new one | ||
| for i, metadataAny := range relation.Metadata.MetadataMessage { |
There was a problem hiding this comment.
Move this logic into https://github.com/authzed/spicedb/blob/main/pkg/namespace/metadata.go and follow a similar style to there
| @@ -77,6 +77,7 @@ message RelationMetadata { | |||
| } | |||
|
|
|||
| RelationKind kind = 1; | |||
| repeated string type_annotations = 2; | |||
There was a problem hiding this comment.
Put this under a TypeAnnotations message so we can change it in the future if we want
| @@ -103,6 +106,24 @@ func translate(tctx *translationContext, root *dslNode) (*CompiledSchema, error) | |||
|
|
|||
| // Check for typechecking after all definitions are processed. | |||
| if slices.Contains(tctx.enabledFlags, "typechecking") { | |||
| resolver := ResolverForCompiledSchema(compiledSchema) | |||
| ts := schema.NewTypeSystem(resolver) | |||
There was a problem hiding this comment.
This should be done as part of the .Validate call on the type system, rather than the schema translator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.