Skip to content

Improve how we select index forcing for CRDB #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josephschorr
Copy link
Member

This uses a less hand-written method and more structural and well tested method to select which index to force, if any

@josephschorr josephschorr requested a review from a team as a code owner June 18, 2025 00:58
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Jun 18, 2025
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 85.24590% with 27 lines in your changes missing coverage. Please review.

Project coverage is 77.40%. Comparing base (328a634) to head (f71fdcc).

Files with missing lines Patch % Lines
internal/datastore/crdb/schema/indexutil.go 88.47% 13 Missing and 5 partials ⚠️
internal/datastore/crdb/reader.go 25.00% 2 Missing and 1 partial ⚠️
internal/datastore/crdb/readwrite.go 40.00% 2 Missing and 1 partial ⚠️
internal/datastore/crdb/schema/forcedindex.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2458      +/-   ##
==========================================
+ Coverage   77.39%   77.40%   +0.01%     
==========================================
  Files         422      424       +2     
  Lines       51275    51391     +116     
==========================================
+ Hits        39679    39773      +94     
- Misses       9094     9110      +16     
- Partials     2502     2508       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This uses a less hand-written method and more structural and well tested method to select which index to force, if any
@josephschorr josephschorr force-pushed the crdb-index-forcing-improvements branch from f69b349 to f71fdcc Compare June 18, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant