Skip to content

fix: correct typos in parser.go and tmpnet documentation #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix: correct typos in parser.go and tmpnet documentation #3712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5607e1a
Update parser.go
avorylli Feb 9, 2025
76808f3
Update README.md
avorylli Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/fixture/tmpnet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ metrics and logs.

Collection of logs and metrics is enabled for CI jobs that use
tmpnet. Each job will execute a step titled `Notify of metrics
availability` that emits a link to grafana parametized to show results
for the job. Additional links to grafana parametized to show results
availability` that emits a link to grafana parameterized to show results
for the job. Additional links to grafana parameterized to show results
for individual network will appear in the logs displaying the start of
those networks.
4 changes: 2 additions & 2 deletions version/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ func Parse(s string) (*Semantic, error) {

func parseVersions(s string) (int, int, int, error) {
splitVersion := strings.SplitN(s, ".", 3)
if numSeperators := len(splitVersion); numSeperators != 3 {
return 0, 0, 0, fmt.Errorf("%w: expected 3 only got %d", errMissingVersions, numSeperators)
if numSeparators := len(splitVersion); numSeparators != 3 {
return 0, 0, 0, fmt.Errorf("%w: expected 3 only got %d", errMissingVersions, numSeparators)
}

major, err := strconv.Atoi(splitVersion[0])
Expand Down