Skip to content

[ci] Update to golangci-lint version compatible with go 1.23 #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

maru-ava
Copy link
Contributor

Why this should be merged

Local execution of lint.sh results in the following error despite the installed version of golang being the official 1.23.6 binary for linux/arm64.

Error: can't load config: the Go language version (go1.22) used to build golangci-lint is lower than the targeted Go version (1.23.6)
Failed executing command with error: can't load config: the Go language version (go1.22) used to build golangci-lint is lower than the targeted Go version (1.23.6)

Updating to a newer version of golangci-lint removes this error.

@maru-ava maru-ava added the ci This focuses on changes to the CI process label Feb 22, 2025
@maru-ava maru-ava self-assigned this Feb 22, 2025
@@ -20,12 +20,11 @@ run:
build-tags:
- test

output:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is in response to the newer version of golangci-lint complaining thus:

^[[33mWARN^[[0m [config_reader] The configuration option `output.uniq-by-line` is deprecated, please use `issues.uniq-by-line`

@StephenButtolph StephenButtolph added this pull request to the merge queue Feb 22, 2025
Merged via the queue into master with commit 169e7fd Feb 22, 2025
22 checks passed
@StephenButtolph StephenButtolph deleted the update-golangci-lint branch February 22, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants