Print git commit version upon startup #3771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
approved these changes
Mar 6, 2025
maru-ava
approved these changes
Mar 6, 2025
aaronbuchwald
approved these changes
Mar 7, 2025
Jobs executing on PRs based on fork branches won't have access to the secrets required to configure collectors for logs and metrics. Disabling the collection in the custom action avoids failing such jobs. This was the behavior prior to the switch to starting collectors with golang.
Signed-off-by: Yacov Manevich <[email protected]>
StephenButtolph
approved these changes
Mar 10, 2025
cam-schultz
pushed a commit
that referenced
this pull request
Mar 24, 2025
Signed-off-by: Yacov Manevich <[email protected]> Co-authored-by: Maru Newby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In order to better know the exact code version that is run, it's useful if the node would print it upon startup.
How this works
Just prints the commit which is set at compile time.
How this was tested
built the binary and ran it.
Need to be documented in RELEASES.md?
no