Skip to content

[ci] Disable monitoring for jobs of PRs of fork branches #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

maru-ava
Copy link
Contributor

@maru-ava maru-ava commented Mar 10, 2025

Why this should be merged

Jobs executing on PRs based on fork branches won't have access to the secrets required to configure collectors for logs and metrics. Disabling the collection in the custom action avoids failing such jobs. This was the behavior prior to the switch to starting collectors with golang.

How this works

  • makes collector start and collection checks in the run-monitored-tmpnet-cmd custom action conditional on credentials being non-empty
  • emits an annotation if collector credentials are missing in the hopes of notifying interested parties of unintended misconfiguration

How this was tested

  • CI (should show no change)
  • Passing run from a fork branch

Need to be documented in RELEASES.md?

N/A

@maru-ava maru-ava added the ci This focuses on changes to the CI process label Mar 10, 2025
@maru-ava maru-ava self-assigned this Mar 10, 2025
@github-project-automation github-project-automation bot moved this to Backlog 🗄️ in avalanchego Mar 10, 2025
@maru-ava maru-ava moved this from Backlog 🗄️ to In Review 👀 in avalanchego Mar 10, 2025
@maru-ava maru-ava force-pushed the ci-skip-monitoring-fork-branches branch from c49c977 to 25090c7 Compare March 10, 2025 18:11
Jobs executing on PRs based on fork branches won't have access to the
secrets required to configure collectors for logs and
metrics. Disabling the collection in the custom action avoids failing
such jobs. This was the behavior prior to the switch to starting
collectors with golang.
@maru-ava maru-ava force-pushed the ci-skip-monitoring-fork-branches branch from 25090c7 to 220c2f8 Compare March 10, 2025 18:14
@maru-ava maru-ava changed the title [ci] Disable monitoring of fork branches [ci] Disable monitoring for jobs of PRs of fork branches Mar 10, 2025
Copy link
Contributor

@yacovm yacovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StephenButtolph StephenButtolph added this pull request to the merge queue Mar 10, 2025
Merged via the queue into master with commit 6d89fae Mar 10, 2025
23 checks passed
@StephenButtolph StephenButtolph deleted the ci-skip-monitoring-fork-branches branch March 10, 2025 19:43
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in avalanchego Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants