Skip to content

Split processor into separate module #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Conversation

SentryMan
Copy link
Collaborator

Annotations shouldn't be in the same module as processors.

  • move internal packages to their own module
  • add new module as a compile dependency to prisms

@rbygrave
Copy link
Contributor

Annotations shouldn't be in the same module as processors.

Isn't prisms the exception to the rule though?

@SentryMan
Copy link
Collaborator Author

there is one edge case where a modular processor doesn't use

			<plugin>
				<artifactId>maven-compiler-plugin</artifactId>
				<executions>
					<execution>
						<id>default-compile</id>
						<configuration>
							<compilerArgument>-proc:none</compilerArgument>
						</configuration>
					</execution>
				</executions>
			</plugin>

and wants to use prisms as a provided dependency. Currently, it will not work.

@SentryMan
Copy link
Collaborator Author

this one edge case happens when a processor generates its META-INF services with another AP.

@rbygrave rbygrave self-requested a review August 16, 2023 05:58
@SentryMan SentryMan merged commit 18a0e5a into avaje:main Aug 16, 2023
@SentryMan SentryMan deleted the module branch August 16, 2023 12:39
@SentryMan SentryMan added the enhancement New feature or request label Aug 17, 2023
@SentryMan SentryMan added this to the 1.12 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants