Skip to content

Remove compiler option override needed for TypeScript 4.x. #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

kebbell
Copy link
Contributor

@kebbell kebbell commented Nov 5, 2024

Please review

@novemberborn novemberborn changed the title Fixed a bug Remove compiler option override needed for TypeScript 4.x. Nov 15, 2024
Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

tsconfig.json Outdated
// See <https://github.com/microsoft/TypeScript/issues/50544>. This does not
// seem solved with 4.8.3.
"forceConsistentCasingInFileNames": false,
"forceConsistentCasingInFileNames": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default option in the base config, so the entire compilerOptions block can be removed instead.

tsconfig.json Outdated
},
"include": [
"test",
"test-tap",
"test-types"
]
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary empty line.

@novemberborn novemberborn dismissed their stale review June 6, 2025 20:41

Applied changes.

@novemberborn novemberborn merged commit 50e02d5 into avajs:main Jun 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants