Skip to content

Add aws distro version to sdk.version resource attributes. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

zzhlogin
Copy link
Contributor

@zzhlogin zzhlogin commented Feb 22, 2024

Issue #, if available:

In Java, telemetry.auto.version resource attribute is being deprecated (PR). However, We don't find any related change in upstream. It is still being used, so we are not going to deprecate it in aws-opentelemetry-distro for now. And we use aws-opentlemetry-distro version with "-aws" post-fix to be the telemetry.auto.version , which match with the Java implementation.

Testing:
Tested resource attributed are generated:
Before the change:

"resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.22.0', 'service.name': 'unknown_service', 'telemetry.auto.version': '0.43b0'}, maxlen=None)"

After the change:

"resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.22.0', 'service.name': 'unknown_service', 'telemetry.auto.version':'0.0.1-aws'}, maxlen=None)"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zzhlogin zzhlogin requested a review from a team February 22, 2024 19:53
@srprash srprash requested a review from thpierce February 26, 2024 16:59
Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your overview comment is confusing:

This PR set telemetry.auto.version to be the version of aws-opentelemetry-distro pkg.

Actually, we are setting telemetry.sdk.version.

Although In Java, telemetry.distro.version resource attribute is being deprecated.

What is telemetry.distro.version? It's not referenced in this PR.

We don't find any related change in upstream. It is still being used, so we are not going to deprecate it in aws-opentelemetry-distro.

This is a bit of a confusing line of thought. It's not super clear why we are talking about deprecating things.

It would be helpful to explain a) what are these ResourceAttributes used for, b) what was the behaviour before, c) why it was a problem, and d) how this change solves that problem. In your testing, you should show a before and after.

Also why do we need to do this in Python, but not in Java?

@zzhlogin zzhlogin merged commit 71f4007 into main Feb 27, 2024
@zzhlogin zzhlogin deleted the distro_version branch February 27, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants