-
Notifications
You must be signed in to change notification settings - Fork 474
Add more event handling unit tests #3063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2434dcf
to
f413f0d
Compare
ltrung
previously approved these changes
Apr 15, 2025
xuesichao
previously approved these changes
Apr 15, 2025
ziyiz-amzn
approved these changes
Apr 15, 2025
ziyiz-amzn
reviewed
Apr 15, 2025
ziyiz-amzn
reviewed
Apr 16, 2025
ziyiz-amzn
requested changes
Apr 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f413f0d
to
4a3c54f
Compare
ziyiz-amzn
reviewed
Apr 17, 2025
091d82e
to
d12d301
Compare
ziyiz-amzn
reviewed
Apr 21, 2025
ziyiz-amzn
reviewed
Apr 21, 2025
ziyiz-amzn
previously approved these changes
Apr 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor comments.
xuesichao
previously approved these changes
Apr 22, 2025
d12d301
to
e503dd9
Compare
ziyiz-amzn
approved these changes
Apr 23, 2025
xuesichao
approved these changes
Apr 23, 2025
e503dd9
to
d89368c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add more event handling unit tests
Testing:
npm run test:slow
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
NA
Checklist:
Have you successfully run
npm run build:release
locally?Yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.