Skip to content

Add more event handling unit tests #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

dylonChime
Copy link
Contributor

Description of changes:
Add more event handling unit tests

Testing:
npm run test:slow

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
NA

Checklist:

  1. Have you successfully run npm run build:release locally?
    Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dylonChime dylonChime requested a review from a team as a code owner April 12, 2025 00:27
@dylonChime dylonChime force-pushed the add-more-event-handling-unit-tests branch 7 times, most recently from 2434dcf to f413f0d Compare April 15, 2025 07:04
ltrung
ltrung previously approved these changes Apr 15, 2025
xuesichao
xuesichao previously approved these changes Apr 15, 2025
@ziyiz-amzn ziyiz-amzn self-requested a review April 16, 2025 00:13
Copy link
Collaborator

@ziyiz-amzn ziyiz-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylonChime dylonChime dismissed stale reviews from xuesichao and ltrung via 4a3c54f April 17, 2025 19:43
@dylonChime dylonChime force-pushed the add-more-event-handling-unit-tests branch from f413f0d to 4a3c54f Compare April 17, 2025 19:43
@dylonChime dylonChime force-pushed the add-more-event-handling-unit-tests branch 5 times, most recently from 091d82e to d12d301 Compare April 21, 2025 04:31
ziyiz-amzn
ziyiz-amzn previously approved these changes Apr 21, 2025
Copy link
Collaborator

@ziyiz-amzn ziyiz-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments.

xuesichao
xuesichao previously approved these changes Apr 22, 2025
@dylonChime dylonChime dismissed stale reviews from xuesichao and ziyiz-amzn via e503dd9 April 23, 2025 17:42
@dylonChime dylonChime force-pushed the add-more-event-handling-unit-tests branch from d12d301 to e503dd9 Compare April 23, 2025 17:42
@dylonChime dylonChime force-pushed the add-more-event-handling-unit-tests branch from e503dd9 to d89368c Compare April 23, 2025 20:54
@dylonChime dylonChime merged commit 320ba84 into main Apr 23, 2025
11 checks passed
@dylonChime dylonChime deleted the add-more-event-handling-unit-tests branch April 23, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants