BugFix: Aggregrate neuroncore utilization across core/device pair #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/processors/gpuattributes/internal/awsneuron_metric_modifier.go
Outdated
Show resolved
Hide resolved
plugins/processors/gpuattributes/internal/awsneuron_metric_modifier.go
Outdated
Show resolved
Hide resolved
movence
previously approved these changes
Jun 9, 2025
movence
approved these changes
Jun 10, 2025
aditya-purang
approved these changes
Jun 10, 2025
sky333999
reviewed
Jun 10, 2025
| @@ -48,6 +49,8 @@ const ( | |||
| RuntimeTagOverride = "DEFAULT" | |||
| NeuronExecutionErrorsAggregatedMetric = containerinsightscommon.NeuronExecutionErrors + "_total" | |||
| NeuronDeviceHardwareEccEventsAggregatedMetric = containerinsightscommon.NeuronDeviceHardwareEccEvents + "_total" | |||
| NeuronCoreLabel = "neuroncore" | |||
| NeuronCorePerDevice = 2 | |||
There was a problem hiding this comment.
nit: mind fixing the indent on the prior line? if not, itll just happen the next time someone touches this file.
Can be done when we have to update the go.mod to bring in the receiver changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
BugFix: The
gpuattributesprocessor currently does not aggregateneuroncore_utilizationmetrics across Cores and neuron Runtimes, this results in inaccurate utilization metrics per core.Description of changes
The change aggregates the core utilization values by taking the max utilization across the same core/device pair across runtimes.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Deployed a custom agent to check the behavior.
Before:
After:
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint