fix: prompt user explicitly for reason upon denying tool request #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjun37602
changed the title
arjun37602
changed the title
brandonskiser
requested changes
Jun 11, 2025
| @@ -1347,6 +1348,23 @@ impl ChatContext { | |||
| tool_use.accepted = true; | |||
|
|
|||
| return Ok(ChatState::ExecuteTools(tool_uses)); | |||
| // Prompt reason if no selected | |||
| } else if ["n", "N"].contains(&prompt.as_str()) { | |||
There was a problem hiding this comment.
Can you instead just define a variable like tool_use_denied_without_reason or something for the ["n", "N"].contains(&prompt.as_str()) check? In case we also add other cases like "no" etc.
| }; | ||
| reason_prompt.push_str(&reason); | ||
| reason_prompt.push_str( | ||
| ". Take user feedback and try again if reason provided, else continue conversation.", |
There was a problem hiding this comment.
The only way to provide no reason seems to be ctrl+c - in which case, let's not send the request to the model since its response seems to be junk.
Instead, I think the flow should be:
# model requests a tool use
> n
Please provide a reason for denying this tool use, or otherwise continue your conversation:\n\n
# user hits ctrl+c, and gets into the exit flow where we check two consecutive ctrl+c's before exiting
(To exit the CLI, press Ctrl+C or Ctrl+D again or type /quit)
> n
Please provide a reason for denying this tool use, or otherwise continue your conversation:\n\n
# we give the same message if they enter "n" again.
> i instead want this tool use....
# send the response with the abandoned tool use and this new prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: https://t.corp.amazon.com/D232774013
Description of changes: Added new branch logic for user responding no to tool use request. Now we send more informative information to model instead of just 'n'.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.