fix(cli): retain type of context values and not convert them to string #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
==========================================
+ Coverage 79.01% 79.02% +0.01%
==========================================
Files 46 46
Lines 7085 7091 +6
Branches 791 791
==========================================
+ Hits 5598 5604 +6
Misses 1468 1468
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
mrgrain
changed the title
mrgrain
approved these changes
Jun 13, 2025
mrgrain
reviewed
Jun 13, 2025
| context[parts[0]] = parts[1]; | ||
| let parsedValue: any = parts[1]; | ||
| try { | ||
| parsedValue = JSON.parse(parts[1]); |
There was a problem hiding this comment.
note to myself, we might want to limit this to booleans and numbers
mrgrain
reviewed
Jun 13, 2025
Comment on lines
+345
to
+349
| try { | ||
| parsedValue = JSON.parse(parts[1]); | ||
| } catch { | ||
| debug('Non-JSON context value for %s, leaving as string: %s', parts[0], parts[1]); | ||
| } |
There was a problem hiding this comment.
I think we need to be more clever here. JSON.parse(parts[1]) will fail if the value is a regular string like test. This will print debug logs for perfectly fine values:
cdk deploy --context foobar=bar
mrgrain
approved these changes
Jun 13, 2025
|
Discussed with the team and this is a great fix! |
mrgrain
requested changes
Jun 13, 2025
mrgrain
approved these changes
Jun 13, 2025
|
I am getting errors when parsing now 
|
This was referenced Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30583
CLI’s context-passing mechanism relied on serialising every entry to a "KEY=VALUE" string, leading CLI to only allows passing string context, so even JSON booleans (true/false) and numbers became plain strings.
This resulted in losing the typed context, like boolean feature-flags are always being passed as string "true"/"false". This incorrectly passed feature flags caused certain integration tests snapshot in the aws-cdk library to be updated with incorrect values causing the integration tests to fail.
This fix retains the type of context values when passed via CLI, by correctly JSON parsing the context while building user configuration. Values that aren’t valid JSON will fall back to plain strings, so existing workflows should continue working as is. This will restore correct typing for feature flags without disrupting existing tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license