Skip to content

fix(ec2-alpha): addInternetGW handles shared route table for subnets #33824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 2, 2025

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Mar 19, 2025

Issue # (if applicable)

Closes #33672

Reason for this change

Earlier same routes were being added to shared route table between subnets causing deployment failures.

Description of changes

  • Added helper method to unique we don't process single route table twice.
  • Also added return value for IGW and EIGW so that customers can refer them to as target later, similar to other gateway and endpoints.

Describe any new or updated permissions being added

NA

Description of how you validated changes

Added unit test and integration test

Limitation for adding integration test for IPv6, we don't know the AmazonprovidedIPv6 before for which local route gets added and needs to be added in expected assertion.

Error: Resolution error: Resolution error: Resolution error: Found an encoded list token string in a scalar string context. Use 'Fn.select(0, list)' (not 'list[0]') to extract elements from token lists.

        {
          DestinationCidrBlock: vpc.ipv6CidrBlocks[0],
          GatewayId: 'local',
        },

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 19, 2025 04:14
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Mar 19, 2025
@shikha372 shikha372 changed the title fix(eks): fixing the filtering by subnetIDs option fix(ec2-alpha): addInternetGW handles shared route table for subnets Mar 19, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (1c5cbfa) to head (9be81a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33824   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shikha372 shikha372 force-pushed the fix/route-table-addInternetGW branch from d90c4d1 to bb4a645 Compare March 27, 2025 00:31
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@shikha372 shikha372 marked this pull request as ready for review March 27, 2025 03:04
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 27, 2025 03:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 27, 2025
@shikha372 shikha372 force-pushed the fix/route-table-addInternetGW branch from 13956df to 33ef7de Compare March 27, 2025 22:28
@paulhcsun paulhcsun self-assigned this Apr 1, 2025
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise looks good.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 1, 2025
@shikha372 shikha372 force-pushed the fix/route-table-addInternetGW branch 2 times, most recently from 14d1e61 to a9b3132 Compare April 1, 2025 21:34
@shikha372 shikha372 force-pushed the fix/route-table-addInternetGW branch from a9b3132 to 133f649 Compare April 1, 2025 21:37
@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Apr 2, 2025

update

✅ Branch has been successfully updated

Copy link
Contributor

mergify bot commented Apr 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9be81a6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Apr 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3154d01 into aws:main Apr 2, 2025
20 checks passed
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(@aws-cdk/aws-ec2-alpha): vpc.addInternetGateway cannot handle multiple subnets with shared routetable
3 participants