Skip to content

fix: set the correct port for the SES SMTP servie endpoint #34750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnf
Copy link
Contributor

@johnf johnf commented Jun 18, 2025

Issue # (if applicable)

I didn't create an issue went stright to PR

Reason for this change

const sesEndpoint = new ec2.InterfaceVpcEndpoint(this, 'SESEndpoint', {
  service: ec2.InterfaceVpcEndpointAwsService.EMAIL_SMTP,
  vpc,
  subnets: {
    subnets,
  },
});

The endpoint helper automatically creates a security group with port 443.
The EMAIL_SMPT helper should set this to 587

Description of changes

I've updated the definition to pass in the correct port overriding the default.

I've worked around this in my own code by not using the predefined helper

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Tested by hand

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 18, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 18, 2025 13:41
@github-actions github-actions bot added the p2 label Jun 18, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ed2635a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants