Skip to content

Prepare Docker images for upcoming CI changes #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nhatnghiho
Copy link
Contributor

Issues:

Addresses #CryptoAlg-2907 and #CryptoAlg-3113

Description of changes:

This PR bundles a few Docker image changes together:

  • Updated the Windows images to Windows 2022 so that we can upgrade our CodeBuild compute type. This is to migrate the high-cost Windows test over to CodeBuild.
  • Added a few packages to our Ubuntu images that's needed for Unbound CI.

Callouts:

This PR also updates how our Powershell scripts handle errors. Previously, any external commands (like docker) will just silently fail, leading to false Windows image build success.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (050d696) to head (6cf898b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   78.93%   78.90%   -0.04%     
==========================================
  Files         622      622              
  Lines      108845   108845              
  Branches    15424    15423       -1     
==========================================
- Hits        85918    85885      -33     
- Misses      22255    22288      +33     
  Partials      672      672              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants