Track accountID endpoint mode in user-agent #3000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
reviewed
Feb 4, 2025
...java/software/amazon/smithy/aws/go/codegen/customization/AccountIdEndpointModeUserAgent.java
Show resolved
Hide resolved
Madrigal
reviewed
Feb 4, 2025
| awsmiddleware "github.com/aws/aws-sdk-go-v2/aws/middleware" | ||
| ) | ||
|
|
||
| type captureUserAgentFeatures struct { |
There was a problem hiding this comment.
Also, I'm currently in the process of testing something very similar, so I'm stealing this
Madrigal
approved these changes
Feb 4, 2025
wty-Bryant
reviewed
Feb 4, 2025
| } | ||
|
|
||
| ctx.writerDelegator().useFileWriter("api_client.go", ctx.settings().getModuleName(), goTemplate(""" | ||
| $aws:D $awsMiddleware:D |
There was a problem hiding this comment.
love the new format of import dependencies
wty-Bryant
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following user agent feature IDs:
Rather than writing a test script for this and demonstrating its output, I figured I'd just add a unit test. Why run something once to validate it when you could just have it validate forevermore?