Update HttpRequestMessageFactory to correctly set the Content-Length header #3768
+18
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the .NET Standard implementation of the
HttpRequestMessageFactory
to correctly set the Content-Length header, particularly for non-seekable streams, by taking the current stream position into account.The issue being addressed was originally fixed in #3631. However, due to the test coverage only verifying behavior when
UseChunkEncoding = false
, the regression was reintroduced when the position adjustment was moved behind a check that only applies to seekable streams.This update ensures that the stream position is correctly accounted for when setting Content-Length, regardless of the stream's seekability.
Motivation and Context
#3629
Testing
DRY_RUN-05ce4689-5754-4c4b-afd9-b0119f943459
.TestResetStreamPosition
test to run with and withoutChunkEncoding
.Screenshots (if appropriate)
Types of changes
Checklist
License