Skip to content

minor - throw NoFilesFound exception on 404 #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2022
Merged

minor - throw NoFilesFound exception on 404 #1290

merged 2 commits into from
Apr 21, 2022

Conversation

kukushking
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Throw NoFilesFound on 404

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking self-assigned this Apr 21, 2022
@kukushking kukushking added this to the 2.16.0 milestone Apr 21, 2022
@kukushking kukushking added the minor release Will be addressed in the next minor release label Apr 21, 2022
@kukushking kukushking linked an issue Apr 21, 2022 that may be closed by this pull request
Please Specify Missing Keys During 'Not Found' Error #1246
Closed
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 28844ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido self-requested a review April 21, 2022 14:24
@kukushking kukushking merged commit 4b18a66 into main Apr 21, 2022
@jaidisido jaidisido deleted the fix-404-exception branch April 21, 2022 14:40
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: d8e4942
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido restored the fix-404-exception branch April 21, 2022 14:58
@jaidisido jaidisido deleted the fix-404-exception branch April 21, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaidisido jaidisido jaidisido approved these changes

Assignees

@kukushking kukushking

Labels
minor release Will be addressed in the next minor release
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

Please Specify Missing Keys During 'Not Found' Error
2 participants
@kukushking @jaidisido