Skip to content

Enable s3.to_parquet to recieve "zstd" compression type #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 6, 2022
Merged

Enable s3.to_parquet to recieve "zstd" compression type #1369

merged 10 commits into from
Jun 6, 2022

Conversation

takeknock
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

  • Enable s3.to_parquet to recieve "zstd" as compression type.

Relates

  • Nothing

@takeknock
Copy link
Contributor Author

@kukushking Colud you approve running workflows as mainttainer? If there is any person with this problmme.(I have fixed mypy error)

@malachi-constant
Copy link
Contributor

@kukushking Colud you approve running workflows as mainttainer? If there is any person with this problmme.(I have fixed mypy error)

@takeknock Ran the workflows, looks like there are just a few flake8 checks failing now. You can always run ./validate.sh locally first before pushing to verify checks will pass.

@malachi-constant
Copy link
Contributor

@takeknock I've reverted the mypy version used in our static checks that forced you to add this commit . You should be ok to revert that and rerun now.

@takeknock
Copy link
Contributor Author

@malachi-constant Thank you for your support and kind instruction. I've also revert needless commit which is for only mypy 0.960.
I've run ./validate.sh and confirmed that code pass validate.sh check.

@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 2, 2022

@malachi-constant Thank you for your support and kind instruction. I've also revert needless commit which is for only mypy 0.960. I've run ./validate.sh and confirmed that code pass validate.sh check.

Of course ! Thanks for your contribution. Looks like checks are passing. I'm going to add some reviewers on this PR and they will get to it soon. Most of the team is on holiday this week.

@malachi-constant malachi-constant added the enhancement New feature or request label Jun 2, 2022
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: e92fe8c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit 07bda17 into aws:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants