Skip to content

Add "INSERT IGNORE" mode to mysql.to_sql() #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 5, 2022
Merged

Add "INSERT IGNORE" mode to mysql.to_sql() #1429

merged 11 commits into from
Jul 5, 2022

Conversation

jacobject
Copy link
Contributor

@jacobject jacobject commented Jul 3, 2022 •
edited
Loading

Feature or Bugfix

  • Feature

Detail

  • Added new mode to mysql.to_sql() to allow records to be inserted using an INSERT IGNORE statement
  • Added test for new mode

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 49daa36
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 44b033d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 8c1eb63
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 3650733
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 548193a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 47f050d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jacobject jacobject marked this pull request as ready for review July 3, 2022 21:02
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 18fe64c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: f378793
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit 36d2e35 into aws:main Jul 5, 2022
jaidisido added a commit that referenced this pull request Jul 5, 2022
@jaidisido
Squashed commit of the following:
96e9c92 
commit 36d2e35
Author: dj-mothman <[email protected]>
Date:   Tue Jul 5 10:00:31 2022 +0100

    Add "INSERT IGNORE" mode to mysql.to_sql() (#1429)

    * Add mode for INSERT INGORE

    * Update comment

    * Update new mode name

    * Update name of new mode

    * Fix syntax

    * Reduce line length

    * Empty commit to retry build

    * Add test

    * Fix test

    Co-authored-by: jaidisido <[email protected]>
    Co-authored-by: Lucas Hanson <[email protected]>

commit ca34dc6
Author: Tim Gates <[email protected]>
Date:   Tue Jul 5 10:56:37 2022 +1000

    docs: Fix a few typos (#1434)

    There are small typos in:
    - awswrangler/catalog/_utils.py
    - awswrangler/redshift.py

    Fixes:
    - Should read `immediately` rather than `immediatly`.
    - Should read `considered` rather than `consided`.

    Co-authored-by: Lucas Hanson <[email protected]>

commit f071cc0
Author: Maximilian <[email protected]>
Date:   Mon Jul 4 17:25:56 2022 +0200

    Return empty DataFrame for empty timestream query (#1430)

    * Return empty DataFrame for empty timestream query

    * Black

    * Trigger CI/CD

    * Fix test query

    * Remove semicolon from query

    * Trigger CI/CD

    Co-authored-by: jaidisido <[email protected]>

commit e43f31b
Author: jaidisido <[email protected]>
Date:   Mon Jul 4 15:57:46 2022 +0100

    Remove boto3_session reference from athena test and opensearch utils module (#1433)

    * Minor - Remove boto3_session reference from athena test and from opensearch utils module

    * Simplify test

    * black

commit 95bc840
Author: Abdel Jaidi <[email protected]>
Date:   Mon Jul 4 12:13:01 2022 +0100

    Minor - Break bump2version in SAR section of Install docs

commit 411fc44
Author: bechbd <[email protected]>
Date:   Mon Jul 4 01:46:05 2022 -0800

    Fixed ISSUE-1406  (#1407)

    * Fixed ISSUE-1406 where edge data frames were having properties set to 'set' cardinality which is not supported.  Version prior to 1.1.1.0 were not throwing an error

    * Fixed formatting issue and updated SPARQL examples in tutorial with more accurate examples

    * Fixed validation issue with the client needing to ensure something is a string

    * Fixed issue with Flake8 validation

    * Minor - Remove quarantine in Neptune tests

    Co-authored-by: Dave Bechberger <[email protected]>
    Co-authored-by: Lucas Hanson <[email protected]>
    Co-authored-by: Abdel Jaidi <[email protected]>

commit 5961d14
Author: kukushking <[email protected]>
Date:   Thu Jun 30 16:38:05 2022 +0100

    validate columns after loading partitions (#1427)

commit b97e086
Author: lucas hanson <[email protected]>
Date:   Tue Jun 28 09:17:21 2022 -0700

    Release 2.16.1: Layers List

commit 4a05b43
Author: Lucas Hanson <[email protected]>
Date:   Mon Jun 27 17:19:35 2022 -0700

    Preparing 2.16.1 (#1421)

commit 66e1d04
Author: Lucas Hanson <[email protected]>
Date:   Thu Jun 23 11:48:37 2022 -0700

    Bug Fix: pq_file.schema.names(): TypeError: 'list' object is not callable (#1412)

    * Reference attribute not callable

    * adding test to validate feature

    * fixing static checks

commit dc555a9
Author: Cyril Fait <[email protected]>
Date:   Wed Jun 22 12:28:58 2022 +0200

    Preparing release 2.16.0

commit a493973
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Jun 22 08:42:57 2022 +0000

    [skip ci] pip(deps-dev): Bump moto from 3.1.12 to 3.1.14

    Bumps [moto](https://github.com/spulec/moto) from 3.1.12 to 3.1.14.
    - [Release notes](https://github.com/spulec/moto/releases)
    - [Changelog](https://github.com/spulec/moto/blob/master/CHANGELOG.md)
    - [Commits](getmoto/moto@3.1.12...3.1.14)

    ---
    updated-dependencies:
    - dependency-name: moto
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 65eb166
Author: William Smith <[email protected]>
Date:   Wed Jun 15 09:45:41 2022 -0500

    make redshift column names quoted identifers

commit a3f8efe
Author: William Smith <[email protected]>
Date:   Wed Jun 15 09:45:16 2022 -0500

    make postgres column names quoted identifiers

commit d689c17
Author: William Smith <[email protected]>
Date:   Wed Jun 15 08:45:40 2022 -0500

    assign join of quoted columns to variable so insertion_columns can be a f-string

commit 8bcb246
Author: William Smith <[email protected]>
Date:   Tue Jun 14 15:51:20 2022 -0500

    Make column names quoted identifiers

    adding double quotes around the column names to make them quoted identifiers
    allows using SQL Server keywords such as "close" or "open" as column names.

commit 1585906
Author: Cyril Fait <[email protected]>
Date:   Thu Jun 9 06:15:23 2022 +0200

    migrating from cx_Oracle to oracledb

commit 4bf77b6
Author: Cyril Fait <[email protected]>
Date:   Thu Apr 14 12:03:52 2022 +0200

    [skip ci] add Oracle support (#629)

commit aa2a3d2
Author: lucas hanson <[email protected]>
Date:   Tue Jun 21 10:34:45 2022 -0700

    Minor: Fixing issue with new engine version naming convention for aurora mysql
@kukushking kukushking added this to the 2.17.0 milestone Jul 5, 2022
@kukushking kukushking added minor release Will be addressed in the next minor release ready to release labels Jul 5, 2022
@jacobject jacobject deleted the mysql-insert-ignore branch July 5, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaidisido jaidisido jaidisido approved these changes

Assignees
No one assigned
Labels
minor release Will be addressed in the next minor release ready to release
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobject @malachi-constant @jaidisido @kukushking