Make use of pyarrow iter_batches #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
added
enhancement
jaidisido
approved these changes
Apr 26, 2021
| use_threads_flag: bool, | ||
| ) -> Iterator[pa.RecordBatch]: | ||
| if chunked is True: | ||
| batch_size = 65_536 |
There was a problem hiding this comment.
I assume this is the default from the iter_batches method 👍🏼
There was a problem hiding this comment.
Yes it's the pyarrow default 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #660:
Description of changes:
When available make use of the new
pyarrowfunctioniter_batches, but keep the old mechanism as a fallback forpyarrow < 3.0.0.I've opted for explicitly checking for the availability of
iter_batchesinstead of a try except block, because of theforloop over the batches and to make sure that the two parsing mechanisms don't get mixed up in case of an unexpected exception.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.