telemetry(amazonq): add languageServerVersion for some agentic chat metrics #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya169
approved these changes
Apr 24, 2025
jpinkney-aws
approved these changes
Apr 24, 2025
justinmk3
reviewed
Apr 24, 2025
| @@ -1169,6 +1169,11 @@ | |||
| "type": "int", | |||
| "description": "Number of code snippets in response" | |||
| }, | |||
| { | |||
| "name": "cwsprChatResponseErrorReason", | |||
There was a problem hiding this comment.
Why are you not using the existing fields reason or reasonDesc ?
There was a problem hiding this comment.
Correct, I haved used the reasonDesc field and not the cwsprChatResponseErrorReason field in this flare pr: aws/language-servers#1076
I was just uplifting the amazonq_messageResponseError metric and its corresponding types from vsc to common
justinmk3
pushed a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Apr 24, 2025
## Problem - toolkit commons needs to be updated so that certain telemetry events from flare have `languageServerVersion` ## Solution - bump aws-toolkit-common version from 1.0.316 to 1.0.317 - remove `amazonq_messageResponseError` because it was uplifted to common: aws/aws-toolkit-common#1019
opieter-aws
pushed a commit
to opieter-aws/aws-toolkit-vscode
that referenced
this pull request
Apr 24, 2025
## Problem - toolkit commons needs to be updated so that certain telemetry events from flare have `languageServerVersion` ## Solution - bump aws-toolkit-common version from 1.0.316 to 1.0.317 - remove `amazonq_messageResponseError` because it was uplifted to common: aws/aws-toolkit-common#1019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
languageServerVersionin agentic chat metricsSolution
languageServerVersionfor these metrics:amazonq_addMessageamazonq_messageResponseErroramazonq_toolUseSuggestedamazonq_interactWithAgenticChatamazonq_messageResponseErrorfrom vsc to commonLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.