Skip to content

fix(amazonq): pass uri.path as workspaceIdentifier when initializing … #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

LiGaCu
Copy link
Contributor

@LiGaCu LiGaCu commented May 12, 2025

Problem

workspaceIdentifier should be a string:

Solution

Update extensionContext.storageUri with extensionContext.storageUri?.path


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

…AmazonQ lsp

## Problem
workspaceIdentifier should be a string:
- aws/language-server-runtimes#497

## Solution
Update ``extensionContext.storageUri`` with ``extensionContext.storageUri?.path``
@LiGaCu LiGaCu requested a review from a team as a code owner May 12, 2025 20:37
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@justinmk3 justinmk3 merged commit ffc0cb4 into aws:master May 12, 2025
27 of 31 checks passed
rli pushed a commit to aws/aws-toolkit-jetbrains that referenced this pull request May 16, 2025
…uageServer (#5725)

AmazonQ LSP needs an identifier for the IDE workspace, which should be stable and unique for each workspace, regardless of IDE restarts or system reboots.

Related `aws/language-server-runtimes` change:
- aws/language-server-runtimes#497



Use `Project.getBasePath()` as such an identifier and pass it when initializing AmazonQ language server.

Similar change on `aws/aws-toolkit-vscode` side:
- aws/aws-toolkit-vscode#7291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants