Skip to content

fix(stepfunctions): Add document URI check for save telemetry and enable deployment from WFS #7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2025

Conversation

l0minous
Copy link
Contributor

@l0minous l0minous commented May 14, 2025

Problem

  • Save telemetry was being recorded for all document saves in VS Code, not just for the active workflow studio document.
  • Save & Deploy functionality required closing Workflow Studio before starting deployment

Solution

  • Add URI comparison check to ensure telemetry is only recorded when the saved document matches the current workflow studio document.
  • Refactored publishStateMachine.ts to accept an optional TextDocument parameter and updated activation.ts to support new interface
  • Removed closeCustomEditorMessageHandler call from saveFileAndDeployMessageHandler

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@l0minous l0minous requested a review from a team as a code owner May 14, 2025 23:52
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@l0minous l0minous changed the title fix(stepFunctions): Add document URI check for save telemetry fix(stepfunctions): Add document URI check for save telemetry May 14, 2025
@l0minous l0minous closed this May 14, 2025
@l0minous l0minous reopened this May 14, 2025
@l0minous l0minous changed the title fix(stepfunctions): Add document URI check for save telemetry fix(stepfunctions): Add document URI check for save telemetry and enable deployment from WFS May 21, 2025
@@ -96,7 +96,7 @@ async function registerStepFunctionCommands(
}),
Commands.register('aws.stepfunctions.publishStateMachine', async (node?: any) => {
const region: string | undefined = node?.regionCode
await publishStateMachine(awsContext, outputChannel, region)
await publishStateMachine({ awsContext: awsContext, outputChannel: outputChannel, region: region })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: even this should work fine

await publishStateMachine({ awsContext outputChannel, region })

not a blocking comment

Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laileni-aws laileni-aws merged commit 771fae8 into aws:master Jun 24, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants