Make AWS Pricing API Region Configurable via Env Var or Parameter #8172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on override Adds support for configuring the AWS pricing API region using the PRICING_REGION_OVERRIDE environment variable or a function parameter. Defaults remain backward compatible with region-based fallbacks and us-east-1.
✅ Deploy Preview for karpenter-docs-prod canceled.
|
rschalo
reviewed
Jun 20, 2025
| func NewAPI(cfg aws.Config, pricingRegionOverride ...string) *pricing.Client { | ||
| pricingRegion := "us-east-1" | ||
|
|
||
| if val := os.Getenv("PRICING_REGION_OVERRIDE"); val != "" { |
There was a problem hiding this comment.
Rather than use the os.Getenv here, can we match the pattern established with other operator options?
karpenter-provider-aws/pkg/operator/options/options.go
Lines 47 to 56 in 352a94b
| return pricing.NewFromConfig(pricingCfg) | ||
| // NewAPI returns a pricing API configured based on a specific region, | ||
| // with an optional override for the pricing endpoint region. | ||
| func NewAPI(cfg aws.Config, pricingRegionOverride ...string) *pricing.Client { |
There was a problem hiding this comment.
Suggested change
| func NewAPI(cfg aws.Config, pricingRegionOverride ...string) *pricing.Client { | |
| func NewAPI(cfg aws.Config, regionOverride string) *pricing.Client { |
Comment on lines
+110
to
+122
| } else if len(pricingRegionOverride) > 0 && pricingRegionOverride[0] != "" { | ||
| // If caller explicitly provided a region, honor it | ||
| pricingRegion = pricingRegionOverride[0] | ||
| } else { | ||
| // Otherwise use existing fallback logic | ||
| if strings.HasPrefix(cfg.Region, "ap-") { | ||
| pricingRegion = "ap-south-1" | ||
| } else if strings.HasPrefix(cfg.Region, "cn-") { | ||
| pricingRegion = "cn-northwest-1" | ||
| } else if strings.HasPrefix(cfg.Region, "eu-") { | ||
| pricingRegion = "eu-central-1" | ||
| } | ||
| } |
There was a problem hiding this comment.
Rather than adding these conditionals, can we just override it if the override is not == ""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for configuring the AWS pricing API region using the PRICING_REGION_OVERRIDE environment variable or a function parameter. Defaults remain backward compatible with region-based fallbacks and us-east-1.
Fixes #8166
Description
feat(pricing): Make AWS Pricing API region configurable
This change allows consumers to override the default pricing region fallback behavior by either:
PRICING_REGION_OVERRIDEenvironment variableregionOverridestring to theNewAPIconstructorThe default region logic (
us-east-1,ap-south-1,cn-northwest-1,eu-central-1) remains as fallback if no override is provided, maintaining backward compatibility. This change supports customers with restricted region access and avoids hardcoding assumptions.How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.