Skip to content

fix: request id and error message in error metric #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

chungjac
Copy link
Contributor

@chungjac chungjac commented Apr 23, 2025

for context, here is the agentic-chat branch pr which i am porting to language-servers: aws/aws-toolkit-vscode#7045

Problem

  • do not have requestID and errorMessage in amazonq_messageResponseError

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner April 23, 2025 00:06
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep track of a follow up item to port the getTelemetryReasonDesc tests from vscode to here

@jpinkney-aws jpinkney-aws merged commit 84bccc6 into aws:main Apr 23, 2025
6 checks passed
@chungjac chungjac deleted the error-metric branch June 4, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants