fix: add result attribute when emitting telemetry event #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
approved these changes
Apr 23, 2025
|
do we need to add a |
jpinkney-aws
approved these changes
Apr 23, 2025
|
I don't think any of these are modeled as succeed/failure metrics. Flare doesn't have the concept of spans |
…mpt should st… (aws#1081) feat: open use input prompt for agentic chat and new prompt should stop current response
## Problem - Existing UX shows multiple context list chatItem cards for list directory tool messages. ## Solution - Use a `messageIdToUpdateListDir` state to store the messageId and update this for next list directory tool messages.  ## TODO: - Need to combine both read and list directory tool messages into one context list. - This code change is equivalent to this PR: aws/aws-toolkit-vscode#7006 in `feature/agentic-chat` branch.
|
Indeed. Flare just emits based on a hook, no evaluation of success or failure for this is implemented. |
Hweinstock
approved these changes
Apr 23, 2025
This was referenced Apr 24, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Telemetry events sent to VSCode are missing a
resultattribute, causing a warning in the VSCode logs:Solution
Add
result: 'Succeeded'to the data when telemetry metrics are emittedTesting
Manually verified E2E that the warning is fixed
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.