feat(chat-client): open use input prompt for agentic chat and new prompt should st… #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…op current response
ctlai95
approved these changes
Apr 23, 2025
|
tests are failing |
kmile
approved these changes
Apr 23, 2025
Hweinstock
approved these changes
Apr 23, 2025
zixlin7
reviewed
Apr 23, 2025
| @@ -90,6 +90,7 @@ export const handleChatPrompt = ( | |||
| _eventId?: string | |||
| ) => { | |||
| let userPrompt = prompt.escapedPrompt | |||
| messager.onStopChatResponse(tabId) | |||
There was a problem hiding this comment.
does this affect regular chat too? maybe that's ok
There was a problem hiding this comment.
It does not affect user experience in anyway and any token cancellation is fine. but yeah added here, so the new user prompt kickstarts stop UI changes.
Hweinstock
approved these changes
Apr 23, 2025
opieter-aws
pushed a commit
to opieter-aws/language-servers
that referenced
this pull request
Apr 23, 2025
…mpt should st… (aws#1081) feat: open use input prompt for agentic chat and new prompt should stop current response
opieter-aws
added a commit
that referenced
this pull request
Apr 23, 2025
* fix: add result attribute when emitting telemetry event * fix: remove comment * fix: unit test * fix: fix unit test * fix: fix unit test * feat(chat-client): open use input prompt for agentic chat and new prompt should st… (#1081) feat: open use input prompt for agentic chat and new prompt should stop current response * fix: ux polish for list directory tool messages. (#1075) ## Problem - Existing UX shows multiple context list chatItem cards for list directory tool messages. ## Solution - Use a `messageIdToUpdateListDir` state to store the messageId and update this for next list directory tool messages.  ## TODO: - Need to combine both read and list directory tool messages into one context list. - This code change is equivalent to this PR: aws/aws-toolkit-vscode#7006 in `feature/agentic-chat` branch. * fix: execute command should show when no approval required & add more loading (#1091) * fix: fix unit test --------- Co-authored-by: invictus <[email protected]> Co-authored-by: Laxman Reddy <[email protected]> Co-authored-by: Zoe Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…op current response
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.