fix: onFileClick logic is crashing the whole process if no workspace …

[volodkevych]

…is open

Problem

This logic was throwing exception and crashing the whole process:

        const workspaceRoot = workspaceUtils.getWorkspaceFolderPaths(this.#features.lsp)[0]
        let absolutePath = path.join(workspaceRoot, params.filePath) <--- HERE, because workspaceRoot is undefined if no workspace is open

Solution

• Move the code for workspace resolution to the proper condition inside of onFileClick
• For context items, pass the full path to client, so that client can return the fullpath back, and full path resolution is not needed anymore
• For cases, where fullpath is not known or not passed for some reason (there can be cases - I did not go through the whole codebase), we still have this full path resolve logic, but now we search in all the workspaces and more importantly - catch the errors

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[volodkevych]

I had to update it, because 6 did not contain fileDetails yet. It does not impact the final bundle as we always include latest Mynah there.

[justinmk3]

Is there a shared module this can live in, instead of this controller? Isn't this a generally useful function?

[volodkevych]

yes, can be refactored to something reusable - for now, it contains prompts specifics