feat: add mcp client #1034
Merged
feat: add mcp client #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bywang56
force-pushed
the
feature/mcp
branch
5 times, most recently
from
d457ca4 to
637ae37
Compare
Randall-Jiang
approved these changes
Apr 22, 2025
ctlai95
reviewed
Apr 22, 2025
| const content = typeof result === 'object' ? JSON.stringify(result) : String(result) | ||
| return { | ||
| output: { | ||
| kind: OutputKind.Text, |
There was a problem hiding this comment.
I see we are hardcoding this, is that expected?
There was a problem hiding this comment.
yes, for not we hard code it as text, this might change as part of the future ux work
ctlai95
reviewed
Apr 22, 2025
| args?: string[] | ||
| env?: Record<string, string> | ||
| disabled?: boolean | ||
| autoApprove?: string[] |
There was a problem hiding this comment.
this is not currently used, the entire validation/approval logic for MCP tools has not been implemented yet, I think in the future we might support some global setting to auto approve all MCP tools
ctlai95
reviewed
Apr 22, 2025
| continue | ||
| } | ||
| const cfg: MCPServerConfig = { | ||
| command: (entry as any).command, |
There was a problem hiding this comment.
nit: maybe put entry into a variable and typecast it to avoid having to keep using as any
ctlai95
reviewed
Apr 22, 2025
| @@ -6,11 +6,13 @@ import { ExecuteBash, ExecuteBashParams } from './executeBash' | |||
| import { LspGetDocuments, LspGetDocumentsParams } from './lspGetDocuments' | |||
| import { LspReadDocumentContents, LspReadDocumentContentsParams } from './lspReadDocumentContents' | |||
| import { LspApplyWorkspaceEdit, LspApplyWorkspaceEditParams } from './lspApplyWorkspaceEdit' | |||
| import path = require('path') | |||
ctlai95
approved these changes
Apr 22, 2025
tanujbhakre
approved these changes
Apr 23, 2025
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Support MCP
Solution
Basic MCP client implementation
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.