fix: validate tool output content size #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmithsz
approved these changes
Apr 24, 2025
tsmithsz
reviewed
Apr 24, 2025
| let maxToolResponseSize | ||
| switch (toolUse.name) { | ||
| case 'fsRead': | ||
| maxToolResponseSize = 200_000 |
There was a problem hiding this comment.
nit: Should we store these as constants somewhere?
There was a problem hiding this comment.
I think we should but not sure where, maybe in runtimes?
There was a problem hiding this comment.
Possibly. I haven't really looked into that package to be honest. Maybe we can just add it to the constants file here or create one for agenticChat: https://github.com/aws/language-servers/blob/main/server/aws-lsp-codewhisperer/src/language-server/chat/constants.ts
|
Does it makes sense to use partial results of a long output by truncating the long output? In the current case we fail the validation and the tool result doesn't get added to the message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Service is sometimes throwing ValidationException with reason
CONTENT_LENGTH_EXCEEDS_THRESHOLDif content becomes too large.Solution
Validate the tool output to ensure the results are not too large
Previous implementation: https://github.com/aws/aws-toolkit-vscode/blob/feature/agentic-chat/packages/core/src/codewhispererChat/tools/toolUtils.ts#L75-L90
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.