fix: pr for eye icon(do not merge) #1365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to show the description for auto executed command and show Run Automatically text.
Solution
This PR enhances the user experience by adding tooltips and changing icons for read-only commands before execution. The implementation adds visual indicators to help users distinguish between read-only operations and those that modify files.
The post-execution handling remains unchanged, as it's currently managed in the #getWritableStream function which doesn't differentiate between command types. Currently, tooltips are not displayed after commands have been executed - this behavior requires further discussion.
Screen.Recording.2025-05-19.at.12.52.21.PM.mov
TO-DO
for Read-only command, we need to show the tooltip after them been executed.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.