Skip to content

feat(amazonq): inline unit test generation #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Jun 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
7fe0b1f
feat(amazonq): enhanced utg
Will-ShaoHua May 21, 2025
1750496
test(amazonq): isTestFile
Will-ShaoHua May 21, 2025
848a50b
test(amazonq): javaTestIntent
Will-ShaoHua May 21, 2025
c54e63a
test(amazonq): py ts js TestIntent
Will-ShaoHua May 21, 2025
b1be159
chore(amazonq): chore
Will-ShaoHua May 21, 2025
1d33836
test(amazonq): inferFocalFilename
Will-ShaoHua May 21, 2025
c6918ed
test(amazonq): inferFocalFilename
Will-ShaoHua May 21, 2025
0d6c098
test(amazonq): extractImportedPaths - 1
Will-ShaoHua May 21, 2025
69441fd
test(amazonq): extractImportedPaths - 2
Will-ShaoHua May 21, 2025
5190fe1
test(amazonq): extractImportedPaths - 3
Will-ShaoHua May 21, 2025
abfc86b
test(amazonq): extractExportedSymbolsFromFile
Will-ShaoHua May 21, 2025
a450339
test(amazonq): extractExportedSymbolsFromFile - 2
Will-ShaoHua May 21, 2025
d88cf49
feat(amazonq): walk implementation
Will-ShaoHua May 27, 2025
2dc1bd5
feat(amazonq): fix java test intent regex
Will-ShaoHua May 27, 2025
80ce2ca
feat(amazonq): add more test intent detection test cases
Will-ShaoHua May 27, 2025
0a2f577
chore(amazonq): jsTsTestIntent
Will-ShaoHua May 27, 2025
bc4d7bb
feat(amazonq): utg hookup
Will-ShaoHua May 27, 2025
029ed6b
feat(amazonq): utg hookup
Will-ShaoHua May 27, 2025
d78c71b
fix(amazonq): bugfix
Will-ShaoHua May 28, 2025
3da31b7
chore(amazonq): nit
Will-ShaoHua May 28, 2025
cd123b9
chore(amazonq): logging
Will-ShaoHua May 28, 2025
517ec28
Merge remote-tracking branch 'upstream/main' into utg-2
Will-ShaoHua May 28, 2025
fca2737
feat(amazonq): loose test intent detection criteria
Will-ShaoHua May 28, 2025
7aecdf6
test(amazonq): fix failing test case
Will-ShaoHua May 28, 2025
1874992
fix(amazonq): sup context should has len <= 10240
Will-ShaoHua May 29, 2025
6cd8d92
test(amazonq): fix TestsFoo.java not detected correctly for utg
Will-ShaoHua Jun 2, 2025
d872700
fix(amazonq): focalfileResolution.extractImportedPaths, continue shou…
Will-ShaoHua Jun 2, 2025
d25cbfc
fix(amazonq): utg test intent not using file basename to check isTest…
Will-ShaoHua Jun 2, 2025
fd5a6f4
fix(amazonq): nit
Will-ShaoHua Jun 2, 2025
2cd3b2f
feat(amazonq): expand python/java test file keyword regex
Will-ShaoHua Jun 2, 2025
c9a47cb
test(amazonq): temporarily disable test
Will-ShaoHua Jun 5, 2025
0f3f6e8
test(amazonq): temporarily disable test
Will-ShaoHua Jun 5, 2025
a8db632
test(amazonq): try fix test failure on windows
Will-ShaoHua Jun 5, 2025
b10b601
test(amazonq): nit
Will-ShaoHua Jun 5, 2025
6373449
test(amazonq): attempt to dianost windows test failure
Will-ShaoHua Jun 5, 2025
8a33f2c
test(amazonq): attempt fix test failure on windows
Will-ShaoHua Jun 5, 2025
12d0f85
fix(amazonq): remove console.log
Will-ShaoHua Jun 5, 2025
4ca6239
fix(amazonq): remove console.log
Will-ShaoHua Jun 5, 2025
0c3f2a5
Merge remote-tracking branch 'upstream/main' into utg-2
Will-ShaoHua Jun 5, 2025
1d2eaed
fix(amazonq): todo
Will-ShaoHua Jun 5, 2025
7c60ba1
fix(amazonq): todo
Will-ShaoHua Jun 5, 2025
1f87cfc
fix(amazonq): revert
Will-ShaoHua Jun 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ export const CodewhispererServerFactory =
}

const supplementalContext = await supplementalContextPromise
// TODO: logging
if (codeWhispererService instanceof CodeWhispererServiceToken) {
requestContext.supplementalContexts = supplementalContext?.supplementalContextItems
? supplementalContext.supplementalContextItems.map(v => ({
Expand Down
3 changes: 2 additions & 1 deletion server/aws-lsp-codewhisperer/src/shared/models/model.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
// Port of implementation in AWS Toolkit for VSCode
// https://github.com/aws/aws-toolkit-vscode/blob/9d8ddbd85f4533e539a58e76f7c46883d8e50a79/packages/core/src/codewhisperer/models/model.ts

export type UtgStrategy = 'ByName' | 'ByContent'
// TODO: consolidate these strategy ids
export type UtgStrategy = 'ByName' | 'ByContent' | 'NEW_UTG'

export type CrossFileStrategy = 'OpenTabs_BM25'

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,281 @@
/*!
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

import * as assert from 'assert'
import * as fs from 'fs'
import * as path from 'path'
import * as os from 'os'
import { FocalFileResolver } from './focalFileResolution'

describe('focalFileResolver', function () {
let sut: FocalFileResolver
let tmpProjectRoot: string

beforeEach(() => {
sut = new FocalFileResolver()
tmpProjectRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'focalFileResolutionTest-'))
})

afterEach(() => {
fs.rmSync(tmpProjectRoot, { recursive: true, force: true })
})

describe('inferFocalFilename', function () {
describe('java', function () {
const testCases = ['FooTest.java', 'FooTests.java', 'TestFoo.java', 'TestsFoo.java']

for (let i = 0; i < testCases.length; i++) {
const testCase = testCases[i]
it(`should infer and return correct source focal file name case ${i}`, () => {
const result = sut.inferFocalFilename(testCase, 'java')
assert.strictEqual(result, 'Foo.java')
})
}
})

describe('python', function () {
const testCases = ['test_py_class.py', 'py_class_test.py']

for (let i = 0; i < testCases.length; i++) {
const testCase = testCases[i]
it(`should infer and return correct source focal file name case ${i}`, () => {
const result = sut.inferFocalFilename(testCase, 'python')
assert.strictEqual(result, 'py_class.py')
})
}
})

describe('js', function () {
const testCases = ['foo.test.js', 'foo.spec.js']

for (let i = 0; i < testCases.length; i++) {
const testCase = testCases[i]
it(`should infer and return correct source focal file name case ${i}`, () => {
const result = sut.inferFocalFilename(testCase, 'javascript')
assert.strictEqual(result, 'foo.js')
})
}
})

describe('ts', function () {
const testCases = ['foo.test.ts', 'foo.spec.ts']

for (let i = 0; i < testCases.length; i++) {
const testCase = testCases[i]
it(`should infer and return correct source focal file name case ${i}`, () => {
const result = sut.inferFocalFilename(testCase, 'typescript')
assert.strictEqual(result, 'foo.ts')
})
}
})
})

describe('extractImportedPaths', function () {
describe('java', function () {
it('case1', function () {
const p = path.join(tmpProjectRoot, 'FooTest.java')
fs.writeFileSync(
p,
`
package com.amazon.q.service;

import com.amazon.q.foo.FooClass;
import com.amazon.q.bar.BarClass;
import com.amazon.q.baz1.baz2.BazClass;

public class TestClass {}
`
)

const actual = sut.extractImportedPaths(p, 'java', tmpProjectRoot)
assert.strictEqual(actual.size, 1)
assert.ok(actual.has(path.join('com', 'amazon', 'q', 'service')))
})
})

describe('python', function () {
it('case1', function () {
const p = path.join(tmpProjectRoot, 'test_py_class.py')
fs.writeFileSync(
p,
`
import pytest
import sys
import os
from py_class import PyClass
from util import (foo,bar,baz)

def test_py_class():
assert True
`
)

const actual = sut.extractImportedPaths(p, 'python', tmpProjectRoot)
assert.strictEqual(actual.size, 5)
assert.ok(actual.has('py_class'))
assert.ok(actual.has('pytest'))
assert.ok(actual.has('sys'))
assert.ok(actual.has('os'))
assert.ok(actual.has('util'))
})
})

describe('ts', function () {
it('case1', function () {
const p = path.join(tmpProjectRoot, 'src', 'test', 'foo.test.ts')
fs.mkdirSync(path.join(tmpProjectRoot, 'src', 'test'), { recursive: true })
fs.writeFileSync(
p,
`
import { foo } from '../foo';
import baz from '../baz';
import * as util from '../utils/util';

test('foo', () => {
expect(foo()).toBe('foo');
});
`
)

const actual = sut.extractImportedPaths(p, 'typescript', tmpProjectRoot)
assert.strictEqual(actual.size, 3)
assert.ok(actual.has(path.join(tmpProjectRoot, 'src', 'foo')))
assert.ok(actual.has(path.join(tmpProjectRoot, 'src', 'baz')))
assert.ok(actual.has(path.join(tmpProjectRoot, 'src', 'utils', 'util')))
})
})

describe('js', function () {})
})

describe('extractImportedSymbols', function () {
it('case1', function () {
const p = path.join(tmpProjectRoot, 'foo.js')
fs.writeFileSync(
p,
`
import { foo, bar } from '../src/sample';
import baz from '../src/sample';`
)

const actual = sut.extractImportedSymbols(p)
assert.strictEqual(actual.size, 3)
assert.ok(actual.has('foo'))
assert.ok(actual.has('bar'))
assert.ok(actual.has('baz'))
})
})

describe('extractExportedSymbolsFromFile', function () {
it('', function () {
fs.mkdirSync(path.join(tmpProjectRoot, 'src', 'test'), { recursive: true })
const p = path.join(tmpProjectRoot, 'src', 'test', 'sample.js')
fs.writeFileSync(
p,
`
export function foo() {}
export const bar = 1;
export default baz;
export { alpha, beta };`
)

const actual = sut.extractExportedSymbolsFromFile(p)
assert.strictEqual(actual.size, 5)
assert.ok(actual.has('foo'))
assert.ok(actual.has('bar'))
assert.ok(actual.has('baz'))
assert.ok(actual.has('alpha'))
assert.ok(actual.has('beta'))
})
})

describe('resolveImportToAbsPath', function () {
it('', function () {
fs.mkdirSync(path.join(tmpProjectRoot, 'src', 'test'), { recursive: true })
const p = path.join(tmpProjectRoot, 'src', 'test', 'foo.test.ts')
const actual = sut.resolveImportToAbsPath(p, '../helper', tmpProjectRoot, 'typescript')
assert.strictEqual(actual, path.join(tmpProjectRoot, 'src', 'helper'))
})

it('alias', function () {
fs.mkdirSync(path.join(tmpProjectRoot, 'src', 'test'), { recursive: true })
const p = path.join(tmpProjectRoot, 'src', 'test', 'foo.test.ts')
const actual = sut.resolveImportToAbsPath('foo.test.ts', '@src/utils', tmpProjectRoot, 'typescript')
assert.strictEqual(actual, path.join(tmpProjectRoot, 'src', 'utils'))
})
})

describe('resolvePackageToPath', function () {
it('dot', function () {
const actual = sut.resolvePackageToPath('com.amazon.q.service', '.')
assert.strictEqual(actual, path.join('com', 'amazon', 'q', 'service'))
})

it('slash', function () {
const actual = sut.resolvePackageToPath('com/amazon/q/service', '/')
assert.strictEqual(actual, path.join('com', 'amazon', 'q', 'service'))
})
})

describe('walk should exclude hidden files and only include files with correct extensions', function () {
/**
* - root/
* - src/
* - foo.ts
* - bar.ts
* - ui/
* - frontend.vue
* - ui.html
* - theme.css
* - test/
* - foo.test.ts
* - bar.test.ts
* - .github/
* - workflows/
* - foo.yml
* - pull_request_template.md
* - .idea
* - aws.xml
* - package.json
* - package-lock.json
* - webpack.config
*/
it('case 1', async function () {
fs.mkdirSync(path.join(tmpProjectRoot, 'src'), { recursive: true })
fs.writeFileSync(path.join(tmpProjectRoot, 'src', 'foo.ts'), 'class Foo')
fs.writeFileSync(path.join(tmpProjectRoot, 'src', 'bar.ts'), 'class Bar')

fs.mkdirSync(path.join(tmpProjectRoot, 'src', 'ui'), { recursive: true })
fs.writeFileSync(path.join(tmpProjectRoot, 'src', 'ui', 'frontend.vue'), '')
fs.writeFileSync(path.join(tmpProjectRoot, 'src', 'ui', 'ui.html'), '')
fs.writeFileSync(path.join(tmpProjectRoot, 'src', 'ui', 'theme.css'), '')

fs.mkdirSync(path.join(tmpProjectRoot, 'src', 'test'), { recursive: true })
fs.writeFileSync(path.join(tmpProjectRoot, 'src', 'test', 'foo.test.ts'), 'class FooTest')
fs.writeFileSync(path.join(tmpProjectRoot, 'src', 'test', 'bar.test.ts'), 'class BarTest')

fs.mkdirSync(path.join(tmpProjectRoot, '.github'), { recursive: true })
fs.mkdirSync(path.join(tmpProjectRoot, '.github', 'workflows'), { recursive: true })
fs.writeFileSync(path.join(tmpProjectRoot, '.github', 'workflows', 'foo.yml'), '')
fs.writeFileSync(path.join(tmpProjectRoot, '.github', 'pull_request_template.md'), '')

fs.mkdirSync(path.join(tmpProjectRoot, '.idea'), { recursive: true })
fs.writeFileSync(path.join(tmpProjectRoot, '.idea', 'aws.xml'), '')

fs.writeFileSync(path.join(tmpProjectRoot, 'package.json'), '')
fs.writeFileSync(path.join(tmpProjectRoot, 'package-lock.json'), '')
fs.writeFileSync(path.join(tmpProjectRoot, 'webpack.config'), '')

const files = await sut.walk(tmpProjectRoot, 'typescript')
const basenames = files.map(it => path.basename(it))

assert.ok(files.length === 4)
assert.ok(basenames.includes('foo.ts'))
assert.ok(basenames.includes('bar.ts'))
assert.ok(basenames.includes('foo.test.ts'))
assert.ok(basenames.includes('bar.test.ts'))
})
})
})
Loading
Loading