Skip to content

fix: only show invalid json error on list mcp server page #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: only show invalid json error on list mcp server page #1513

merged 1 commit into from
Jun 4, 2025

Conversation

chungjac
Copy link
Contributor

@chungjac chungjac commented Jun 4, 2025 •
edited
Loading

Problem

  • Don't show MCP server initialization errors in the MCP overview screen. (As if there are a lot of MCP servers each with long error messages, this can get overwhelming.)

Solution

  • The only error which will show on list mcp servers screen is if they have an invalid mcp.json config file
  • If there are server specific errors, user will click see this error once they click into an MCP server
Screen.Recording.2025-06-04.at.1.45.05.PM.mov

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner June 4, 2025 01:28
@chungjac chungjac marked this pull request as draft June 4, 2025 01:35
@chungjac chungjac force-pushed the list-mcp branch 2 times, most recently from ae9cc57 to 5cd3981 Compare June 4, 2025 20:35
@chungjac chungjac changed the title fix: don't show errors on list mcp server page anymore fix: only show invalid json error on list mcp server page Jun 4, 2025
@chungjac chungjac marked this pull request as ready for review June 4, 2025 20:50
@chungjac chungjac merged commit 1f23675 into aws:agentic-mcp Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishrp-aws ashishrp-aws ashishrp-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chungjac @ashishrp-aws