feat(chat-client): history list and conversation actions #929
Conversation
volodkevych
force-pushed
the
chat-client-history
branch
from
ae61775 to
2b08b93
Compare
|
|
||
| const conversationClicked = (params: ConversationClickResult) => { | ||
| if (!params.success) { | ||
| // TODO: any logging, error for this? |
There was a problem hiding this comment.
Is it even possible to get an error when clicking on a conversation?
| } | ||
| } | ||
|
|
||
| private toConversarionGroups = (groups: ConversationItemGroup[]) => { |
There was a problem hiding this comment.
nit; small typo "conversarion"
| | 'onListConversations' | ||
| | 'onConversationClick' | ||
| 'openTab' | 'sendChatUpdate' | 'onFileClicked' | 'onInlineChatPrompt' | 'sendContextCommands' | 'onCreatePrompt' | ||
| // | 'onListConversations' |
There was a problem hiding this comment.
I'll revert code in language-server - used it for testing.
chat-client/src/client/mynahUi.ts
Outdated
| // Noop not-implemented handlers | ||
| onBeforeTabRemove: undefined, | ||
| onFileActionClick: undefined, | ||
| onStopChatResponse: undefined, | ||
| onQuickCommandGroupActionClick: undefined, | ||
| onChatItemEngagement: undefined, | ||
| onShowMoreWebResultsClick: undefined, | ||
| onFormLinkClick: undefined, | ||
| onFormModifierEnterPress: undefined, |
There was a problem hiding this comment.
should we remove this? We decided to remove in a previous PR here c1aaec0
| @@ -74,6 +74,74 @@ export const QChatServer = | |||
| chat.onTabAdd(params => { | |||
| logging.log(`Adding tab: ${params.tabId}`) | |||
|
|
|||
| chat.sendContextCommands({ | |||
There was a problem hiding this comment.
Is this accidentally committed?
There was a problem hiding this comment.
I'll revert code in language-server - used it for testing.
| tabBarButtons: [ | ||
| { | ||
| id: ChatHistory.TabBarButtonId, | ||
| icon: MynahIcons.COMMENT, |
There was a problem hiding this comment.
this should be MynahIcons.HISTORY
There was a problem hiding this comment.
I see it changed recently. Ok, will change the icon with the change for dynamic configuration for those opitons.
Problem
Current version of chat client does not support conversation history list.
Solution
Added support for list conversations, conversation click and conversation actions click.
Screen.Recording.2025-04-09.at.14.19.19.mov
Unit tests will be added in separate followup PR.
TODOcomments will be fixed in separate PR.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.