Skip to content

Rust: bump msrv to 1.76.0 #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

DavidSouther
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DavidSouther DavidSouther self-assigned this May 28, 2024
@DavidSouther DavidSouther requested a review from cpyle0819 May 28, 2024 19:37
@github-actions github-actions bot added Rust This issue relates to the AWS SDK for Rust (Preview) GitHub settings This affects GitHub settings labels May 28, 2024
@DavidSouther DavidSouther added Task A general update to the code base for language clarification, missing actions, tests, etc. On Call Review needed This work needs an on-call review and removed Rust This issue relates to the AWS SDK for Rust (Preview) GitHub settings This affects GitHub settings labels May 28, 2024
@cpyle0819 cpyle0819 added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels May 28, 2024
@DavidSouther DavidSouther marked this pull request as draft May 28, 2024 19:46
@DavidSouther
Copy link
Contributor Author

Looks like it's failing from zowens/crc32c#67

Which is fixed in smithy-lang/smithy-rs#3665

So... give it a day and it should fix itself?

@cpyle0819 cpyle0819 removed the On Call Review complete On call review complete label May 28, 2024
@github-actions github-actions bot added Rust This issue relates to the AWS SDK for Rust (Preview) GitHub settings This affects GitHub settings labels Jun 3, 2024
@DavidSouther DavidSouther requested a review from cpyle0819 June 3, 2024 14:59
@DavidSouther DavidSouther marked this pull request as ready for review June 3, 2024 14:59
@cpyle0819 cpyle0819 added the On Call Review complete On call review complete label Jun 3, 2024
@cpyle0819 cpyle0819 merged commit e009b8e into awsdocs:main Jun 3, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub settings This affects GitHub settings On Call Review complete On call review complete Rust This issue relates to the AWS SDK for Rust (Preview) Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants