Skip to content

Revert "Parse .xml snippet files in xi:include" #6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

Revert "Parse .xml snippet files in xi:include" #6668

merged 1 commit into from
Jul 17, 2024

Conversation

ford-at-aws
Copy link
Contributor

@ford-at-aws ford-at-aws commented Jul 17, 2024 •
edited
Loading

Reverts #6661

Zonbook error:

    [exec] 2024/07/17 18:37:44 Reading templates from aws-doc-sdk-examples/.doc_gen/templates/zonbook/*.*.
     [exec] panic: template: example_language_template.xml:56: function "hasSuffix" not defined

@ford-at-aws ford-at-aws added Task A general update to the code base for language clarification, missing actions, tests, etc. On Call Review complete On call review complete labels Jul 17, 2024
@ford-at-aws ford-at-aws merged commit e36f582 into main Jul 17, 2024
17 of 19 checks passed
@ford-at-aws ford-at-aws deleted the revert-6661-feat/zonbook-xml-snippet-files branch July 17, 2024 19:00
Laren-AWS added a commit that referenced this pull request Jul 18, 2024
@Laren-AWS
Revert "Revert "Parse .xml snippet files in xi:include" (#6668)"
7eecde0 
This reverts commit e36f582.
@Laren-AWS Laren-AWS mentioned this pull request Jul 18, 2024
Merged
ford-at-aws pushed a commit that referenced this pull request Jul 18, 2024
@Laren-AWS
Revert "Revert "Parse .xml snippet files in xi:include"" (#6670)
7102f0a 
Revert "Revert "Parse .xml snippet files in xi:include" (#6668)"

This reverts commit e36f582.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpyle0819 cpyle0819 cpyle0819 approved these changes

Assignees
No one assigned
Labels
On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ford-at-aws @cpyle0819