Hex encoding and byte buf utilities #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and doesn't 0-terminate; Add helper byte buf reserve function that is relative to the current length of the byte buf
justinboswell
approved these changes
May 1, 2019
include/aws/common/byte_buf.h
Outdated
| * | ||
| */ | ||
| AWS_COMMON_API | ||
| int aws_byte_buf_reserve_from_len(struct aws_byte_buf *buffer, size_t additional_length); |
There was a problem hiding this comment.
[nitpick] Feels like _grow or _expand or _extend, do we not have this pattern anywhere else? reserve_from_len just feels a bit unintuitive to me offhand.
There was a problem hiding this comment.
_reserve_relative was another possibility
added 2 commits
May 1, 2019 14:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New hex encoding variant that does not 0-terminate, resizes as needed, and respects the buffers current position.
New reserve invariant that performs its resizing calculation relative to the current length. Useful to cut down on the number of checked arithmetic operations needed when using reserve.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.