Fix max_pending_connection_acquisitions to respect connection pool size #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 79.59% 79.62% +0.02%
==========================================
Files 27 27
Lines 11684 11684
==========================================
+ Hits 9300 9303 +3
+ Misses 2384 2381 -3 ☔ View full report in Codecov by Sentry. |
waahm7
changed the title
TingDaoK
approved these changes
Sep 10, 2024
graebm
pushed a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The previous implementation was too aggressive regarding max_pending_connection_acquisitions. If the max_connections were 50 and max_pending_connection_acquisitions was 10, the 11th acquire request failed even though it was within the max connection limit. This PR changes the implementation to prioritize max_connections first and only fail the 61st request. This change is similar to Netty Behavior
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.