h2: respect the initial window size setting #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #514 +/- ##
==========================================
+ Coverage 79.52% 79.57% +0.05%
==========================================
Files 27 27
Lines 11701 11714 +13
==========================================
+ Hits 9305 9322 +17
+ Misses 2396 2392 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DmitriyMusatkin
approved these changes
Apr 25, 2025
include/aws/http/connection.h
Outdated
| * `AWS_HTTP2_SETTINGS_INITIAL_WINDOW_SIZE`. | ||
| * The corresponding settings from `initial_settings_array` will override this value. | ||
| * Notes: | ||
| * - the setting value has the limitation of 2^31-1, |
There was a problem hiding this comment.
what happens if its above this number? size_t is 64bits on 64bit hw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.