Be resilient to certain missing fields in metadata.json #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyverald
changed the title
alexeagle
reviewed
Jan 22, 2024
| @@ -17,14 +17,14 @@ export const BUILDOZER_BIN = path.join(process.cwd(), 'bin', 'buildozer') | |||
|
|
|||
| export interface Metadata { | |||
| homepage?: string | |||
| maintainers: Array<{ | |||
There was a problem hiding this comment.
nit: we could consider doing the opposite. We already have a schema validator in the bcr that checks all module metadata is conformant.
(and this Metadata schema ought to be imported from that JSON schema so we know the two repos agree on required fields, etc)
WDYT?
There was a problem hiding this comment.
sure -- I just have no idea how to do any of that :)
I suggest we submit this PR first to make sure we have an updated website build, and then worry about finding engineering time for your suggestion.
hobofan
approved these changes
Jan 23, 2024
|
I open up an issue to use the upstream schema as the basis for our types, to prevent format reading mistakes in the future: #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including
yanked_versionsandmaintainersFixes #134