Remove more hasattr/getattr calls in go_context #4054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
commented
Aug 18, 2024
dzbarsky
force-pushed
the
zbarsky/hasattr
branch
from
15038ac to
e40c290
Compare
fmeum
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
starlark cleanup
What does this PR do? Why is it needed?
The current logic to grab all the providers is confusing; it runs the fallback logics even in the case when
go_context_datais found. Easier to follow when we pass the data in explicitly, and a bit faster as well.I also considered making a
go_context_v2api that doesn't have all the fallbacks and using that to powergo_context, but didn't do it for now.Which issues(s) does this PR fix?
Fixes #
Other notes for review